Scope location and endpoint reference writes to authorized products#15300
Merged
Maffooch merged 1 commit intoJul 23, 2026
Merged
Conversation
svader0
force-pushed
the
harden-location-reference-authz
branch
2 times, most recently
from
July 21, 2026 07:26
88d6aff to
0a9d535
Compare
svader0
marked this pull request as ready for review
July 21, 2026 07:34
|
This pull request contains a critical finding where a sensitive codepath file,
🔴 Configured Sensitive Codepath Modified by Non-Allowed Author in
|
| Vulnerability | Configured Sensitive Codepath Modified by Non-Allowed Author |
|---|---|
| Description | File 'dojo/api_v2/serializers.py' matches configured sensitive codepath pattern 'dojo/api_v2/*.py' and was modified by 'svader0' (commit 8c77d9a) who is not in the allowed authors list. |
We've notified @mtesauro.
Comment to provide feedback on these findings.
Report false positive: @dryrunsecurity fp [FINDING ID] [FEEDBACK]
Report low-impact: @dryrunsecurity nit [FINDING ID] [FEEDBACK]
Example: @dryrunsecurity fp drs_90eda195 This code is not user-facing
All finding details can be found in the DryRun Security Dashboard.
svader0
force-pushed
the
harden-location-reference-authz
branch
from
July 21, 2026 15:46
0a9d535 to
b435880
Compare
valentijnscholten
added a commit
that referenced
this pull request
Jul 21, 2026
v3 security-parity review of three open v2 hardening PRs (#15300, #15296, #15191): #15300 IMMUNE (v3 locations read-only, no reference- write surface); #15296 IMMUNE (configuration_permissions not on the v3 user write surface); #15191 identity half was a REAL GAP now fixed. Gap: get_authorized_users returns co-members, so a non-superuser with view_user+change_user could PATCH/PUT a visible co-member's email or username -> account takeover via password reset. Adds _enforce_identity_field_rules (mirrors UserSerializer.validate()): superuser unrestricted, self-edit allowed, email/username change to another account -> 400; create is a no-op. Wired into PATCH and PUT after the superuser/staff gate; deny-by-default sweep unchanged. +6 tests. (API_V3_PLAN.md also carries the examples-refresh §12 row committed next.)
Hardening to object-level authorization on several API and UI write paths that associate locations and endpoints with findings and products. These paths now restrict the selectable references to the objects the requesting user is authorized for, matching the scoping the UI forms and dedicated viewsets already apply. Adds regression tests. No functional change for correctly-permissioned users.
svader0
force-pushed
the
harden-location-reference-authz
branch
from
July 22, 2026 18:48
b435880 to
8c77d9a
Compare
devGregA
approved these changes
Jul 22, 2026
devGregA
left a comment
devGregA
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the change and the added regression tests — looks good, and CI is green. Thanks Sam! ✅
blakeaowens
approved these changes
Jul 22, 2026
Maffooch
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardening and consistency improvement to object-level authorization on several API and UI write paths that associate locations and endpoints with findings and products.
These paths now restrict the selectable references to objects the requesting user is authorized for, matching the scoping the UI forms and dedicated viewsets already apply. No functional change for correctly-permissioned users.
Adds regression tests covering same-product (allowed) and cross-product (rejected) writes.